joroKr21 opened a new pull request, #10901:
URL: https://github.com/apache/datafusion/pull/10901

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #7779.
   
   ## Rationale for this change
   
   `DataSink` metrics were added in 
https://github.com/apache/datafusion/pull/7778 but the `metrics` interface was 
not correctly implemented by `DataSinkExec`.
   
   ## What changes are included in this PR?
   
   Moves the `metrics` function from `impl DataSinkExec` to `impl ExecutionPlan 
for DataSinkExec`.
   
   ## Are these changes tested?
   
   Not currently.
   
   ## Are there any user-facing changes?
   
   After this change `DataSinkExec` will forward to the `DataSink` metrics as 
intended.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to