eejbyfeldt commented on code in PR #581:
URL: https://github.com/apache/datafusion-comet/pull/581#discussion_r1643343696
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometBatchScanExec.scala:
##########
@@ -144,11 +144,5 @@ case class CometBatchScanExec(wrapped: BatchScanExec,
runtimeFilters: Seq[Expres
}
}
- // Intentionally omitting the return type as it is different depending on
Spark version
- // Spark 3.2.x Seq[InputPartition]
- // Spark 3.3.x Seq[Seq[InputPartition]]
- // TODO: add back the return type after dropping Spark 3.2.0 support
- @transient override lazy val partitions = wrappedScan.partitions
Review Comment:
Based on the comment I would expect this to still be needed but can now have
a return type. But maybe it no longer needed?
```
@transient override lazy val partitions: Seq[Seq[InputPartition]] =
wrappedScan.partitions
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
