kazuyukitanimura commented on code in PR #581:
URL: https://github.com/apache/datafusion-comet/pull/581#discussion_r1643604445
##########
spark/src/main/spark-3.x/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##########
@@ -46,25 +41,14 @@ trait ShimCometScanExec {
.map { a => a.setAccessible(true); a }
.flatMap(_.invoke(wrapped).asInstanceOf[Seq[AttributeReference]])
- // TODO: remove after dropping Spark 3.2 and 3.3 support and directly call
+ // TODO: remove after dropping Spark 3.3 support and directly call
Review Comment:
nit `metadataColumns` (a few lines above) is still needed for Spark 3.3 but
we can update the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
