efredine commented on code in PR #11200:
URL: https://github.com/apache/datafusion/pull/11200#discussion_r1663091676
##########
datafusion/core/src/datasource/physical_plan/parquet/statistics.rs:
##########
@@ -903,6 +917,21 @@ macro_rules! get_data_page_statistics {
new_empty_array(&DataType::Time64(unit.clone()))
}
})
+ },
+ Some(DataType::FixedSizeBinary(size)) => {
+ Ok(Arc::new(
+ FixedSizeBinaryArray::from(
+ [<$stat_type_prefix
FixedLenByteArrayDataPageStatsIterator>]::new($iterator).map(|x| {
+ x.into_iter().filter_map(|x| x).map(|x| {
+ if x.len().try_into() == Ok(*size) {
+ Some(x.data().to_vec())
+ } else {
+ None
+ }
+ })
+ }).flatten().collect::<Vec<_>>()
+ )
+ ))
Review Comment:
so - keeping it consistent with the rest of the code and adding the second
loop it might end up looking like this:
```Rust
Some(DataType::FixedSizeBinary(size)) => {
Ok(Arc::new(
FixedSizeBinaryArray::from(
[<$stat_type_prefix
FixedLenByteArrayDataPageStatsIterator>]::new($iterator).map(|x| {
x.into_iter().filter_map(|x| x.and_then(|x| {
if x.len().try_into() == Ok(*size) {
Some(x.data().to_vec())
} else {
log::debug!(
"FixedSizeBinary({}) statistics
is a binary of size {}, ignoring it.",
size,
x.len(),
);
None
}
}))
})
.flatten()
.collect::<Vec<_>>()
.iter()
.map(|x| x.as_slice())
.collect::<Vec<_>>()
)
))
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
