efredine commented on PR #11200:
URL: https://github.com/apache/datafusion/pull/11200#issuecomment-2204297426

   Maybe better, but still iterating twice:
   ```Rust
                  Some(DataType::FixedSizeBinary(size)) => {
                       Ok(Arc::new(
                           FixedSizeBinaryArray::from(
                               [<$stat_type_prefix 
FixedLenByteArrayDataPageStatsIterator>]::new($iterator).map(|x| {
                                   x.into_iter().filter_map(|x| x.and_then(|x| {
                                       if x.len().try_into() == Ok(*size) {
                                           Some(x)
                                       } else {
                                           log::debug!(
                                               "FixedSizeBinary({}) statistics 
is a binary of size {}, ignoring it.",
                                               size,
                                               x.len(),
                                           );
                                           None
                                       }
                                   }))
                               })
                               .flatten()
                               .collect::<Vec<_>>()
                               .iter()
                               .map(|x| x.data())
                               .collect::<Vec<&[u8]>>()
                           )
                       ))
                   },
    ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to