alamb commented on code in PR #11394:
URL: https://github.com/apache/datafusion/pull/11394#discussion_r1672793785
##########
datafusion/core/tests/sql/sql_api.rs:
##########
@@ -113,6 +113,40 @@ async fn unsupported_statement_returns_error() {
ctx.sql_with_options(sql, options).await.unwrap();
}
+#[tokio::test]
+async fn empty_statement_returns_error() {
+ let ctx = SessionContext::new();
+ ctx.sql("CREATE TABLE test (x int)").await.unwrap();
+
+ let state = ctx.state();
+
+ // Give it an empty string which contains no statements
+ let plan_res = state.create_logical_plan("").await;
+ assert_eq!(
+ plan_res.unwrap_err().strip_backtrace(),
+ "This feature is not implemented: No SQL statements were provided in
the query string"
+ );
+}
+
+#[tokio::test]
+async fn multiple_statements_returns_error() {
+ let ctx = SessionContext::new();
+ ctx.sql("CREATE TABLE test (x int)").await.unwrap();
+
+ let state = ctx.state();
+
+ // Give it a string that contains multiple statements
+ let plan_res = state
+ .create_logical_plan(
+ "INSERT INTO test (x) VALUES (1); INSERT INTO test (x) VALUES (2)",
+ )
+ .await;
+ assert_eq!(
+ plan_res.unwrap_err().strip_backtrace(),
+ "This feature is not implemented: The context currently only supports
a single SQL statement"
Review Comment:
thank you for adding additional test coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
