viirya commented on code in PR #11400:
URL: https://github.com/apache/datafusion/pull/11400#discussion_r1672834549
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -53,6 +53,8 @@ pub struct BinaryExpr {
left: Arc<dyn PhysicalExpr>,
op: Operator,
right: Arc<dyn PhysicalExpr>,
+ /// Specifies whether an error is returned on overflow or not
+ fail_on_overflow: bool,
Review Comment:
Comet can use this when constructing these physical expressions. For
DataFusion, it can choose to set this flag on for ansi compliant cases/configs
if any.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
