andygrove commented on PR #11400: URL: https://github.com/apache/datafusion/pull/11400#issuecomment-2221538479
> Related: #10744 > > I have a personal branch where I[ maintain a 'safe' mode for to_timestamp ](https://github.com/Omega359/arrow-datafusion/blob/feature/safe_timestamp_and_date_parsing/datafusion/functions/src/datetime/to_timestamp.rs#L82)and to_date functions. It would be nice to get that sort of functionality into the core however I would only really want to do it if it could be driven via config somehow. My attempts to make that work didn't pan out well and the best approach is likely one where invoke method is provided state (sessionState, SessionConfig, something) where we could query the config for flag(s) and adjust behaviour on the fly based on that. Can you remind me why you need the physical expr to have access to configs at runtime rather than having the planner pass the relevant configs into the expressions when they are created? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
