alamb commented on code in PR #19994:
URL: https://github.com/apache/datafusion/pull/19994#discussion_r2743843664
##########
datafusion/physical-expr/benches/case_when.rs:
##########
@@ -517,5 +519,106 @@ fn benchmark_lookup_table_case_when(c: &mut Criterion,
batch_size: usize) {
}
}
+fn benchmark_divide_by_zero_protection(c: &mut Criterion, batch_size: usize) {
Review Comment:
Could you please pull this additional benchmark code code into its own PR
we could then use our benchmarking scripts to compare performance of this PR
with main?
Thank you 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
