CuteChuanChuan commented on code in PR #19994:
URL: https://github.com/apache/datafusion/pull/19994#discussion_r2746754047
##########
datafusion/physical-expr/benches/case_when.rs:
##########
@@ -517,5 +519,106 @@ fn benchmark_lookup_table_case_when(c: &mut Criterion,
batch_size: usize) {
}
}
+fn benchmark_divide_by_zero_protection(c: &mut Criterion, batch_size: usize) {
Review Comment:
Hi @alamb, thanks for pointing this out. The PR including benchmark code
only is at #20076.
Once that's merged, should I rebase this PR on top of main so the
benchmarking scripts can compare the optimization against the baseline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
