mbutrovich commented on PR #3368: URL: https://github.com/apache/datafusion-comet/pull/3368#issuecomment-3841041172
A couple of thoughts as I mark this ready for review: 1. This slowed down the build-release-comet.sh slightly, but not egregiously. It's still a "run it and go make lunch" script in my mind. 2. These targets are not tested in CI, and they weren't before either. CI runs its builds as the generic "before" scenario in my tables. I tested changing them to match these targets, and the initial Rust library build went from a few minutes to 10-15 minutes in CI. Test runs went a little bit faster. I'm actually of the mind that that is an acceptable scenario to get the instructions tested that we intend to ship as binaries, but that could be a followup PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
