mbutrovich commented on code in PR #3368:
URL: https://github.com/apache/datafusion-comet/pull/3368#discussion_r2758855321
##########
Makefile:
##########
@@ -83,7 +83,7 @@ core-arm64:
cd native && RUSTFLAGS="-Ctarget-cpu=apple-m1"
CC=arm64-apple-darwin21.4-clang CXX=arm64-apple-darwin21.4-clang++
CARGO_FEATURE_NEON=1 cargo build --target aarch64-apple-darwin --release
$(FEATURES_ARG)
mkdir -p common/target/classes/org/apache/comet/darwin/aarch64
cp native/target/aarch64-apple-darwin/release/libcomet.dylib
common/target/classes/org/apache/comet/darwin/aarch64
- cd native && RUSTFLAGS="-Ctarget-cpu=native" cargo build --release
$(FEATURES_ARG)
+ cd native && RUSTFLAGS="-Ctarget-cpu=neoverse-n1" cargo build --release
$(FEATURES_ARG)
Review Comment:
This is for local development I guess, but made consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
