Jefffrey commented on issue #16054: URL: https://github.com/apache/datafusion/issues/16054#issuecomment-3850721213
Thanks @AndreaBozzo Would you be able to expand on this part? > However, `SchemaDisplay` output is also used as a **field-matching key by optimizers** (e.g. `common_subexpr_eliminate`, `push_down_filter`, `decorrelate`). These optimizers compare `schema_name()` strings to match fields across plan nodes. Changing the format of `SchemaDisplay` changes these keys, which breaks field resolution. Does this just mean we need to update the tests? Because if we change how `SchemaDisplay` is computed for binary expressions, this shouldn't affect optimizer key lookup since the column name should be consistent with the new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
