Jefffrey commented on issue #16054: URL: https://github.com/apache/datafusion/issues/16054#issuecomment-3857375682
> I owe a correction on my previous comment. > > After re-investigating, the test failures in PR [#19916](https://github.com/apache/datafusion/pull/19916) were just snapshot mismatches, not actual optimizer breakage. The schema_name() keys are used within single optimization passes, so as long as the format change is consistent, field-matching works fine. > > I misread the failures during a frustrating debugging session (multiple crashes didn't help my judgment) and assumed the worst. The fix was actually correct, I just needed to update the test expectations instead of reverting. Would you be interested in reattempting the PR, implementing the fix for `SchemaDisplay` (and `SqlDisplay`)? I think then we would be good to close this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
