kumarUjjawal commented on code in PR #20154:
URL: https://github.com/apache/datafusion/pull/20154#discussion_r2767273412
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -400,6 +417,8 @@ fn update_hash_for_dict_key(
dict_hashes: &[u64],
dict_values: &dyn Array,
idx: usize,
+ // `multi_col` is the historical name for what is now referred to as
`rehash` elsewhere
Review Comment:
Made some changes, also did a minor refactor, there is another opportunity
for the refactor to centralize the common “compute per-row nested hash → apply
rehash (init vs combine) → hash null rows” logic in a shared helper, so each
nested hasher mostly just computes a row_hash and delegates the buffer
update/null handling. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
