Jefffrey commented on code in PR #20154:
URL: https://github.com/apache/datafusion/pull/20154#discussion_r2780978390
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -484,22 +505,49 @@ fn hash_map_array(
let mut values_hashes = vec![0u64; array.entries().len()];
create_hashes(array.entries().columns(), random_state, &mut
values_hashes)?;
- // Combine the hashes for entries on each row with each other and previous
hash for that row
- if let Some(nulls) = nulls {
+ // Combine the hashes for entries on each row with each other.
+ // When `rehash=true`, combine the per-row map hash into the existing
accumulator.
Review Comment:
Refer to my previous comment about not duplicating this explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
