Jefffrey commented on code in PR #20154:
URL: https://github.com/apache/datafusion/pull/20154#discussion_r2768721673
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -400,6 +417,8 @@ fn update_hash_for_dict_key(
dict_hashes: &[u64],
dict_values: &dyn Array,
idx: usize,
+ // `multi_col` is the historical name for what is now referred to as
`rehash` elsewhere
Review Comment:
I'd be careful of this approach, as we'd want to pull as many checks outside
the hotloop as we can; checking `rehash` each time we compute a hash is
inefficient compared to checking once before the loop, as many other functions
here do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
