alamb commented on PR #20159:
URL: https://github.com/apache/datafusion/pull/20159#issuecomment-3856801501
I tried the reproducer and now it fails like this
```
./target/profiling/datafusion-cli -m 1G -c "SELECT \"UserID\",
extract(minute FROM to_timestamp_seconds(\"EventTime\")) AS m,
\"SearchPhrase\", COUNT(*) FROM
'/Users/andrewlamb/Software/datafusion/benchmarks/data/hits_partitioned' GROUP
BY \"UserID\", m, \"SearchPhrase\" ORDER BY COUNT(*) DESC LIMIT 10;"
DataFusion CLI v52.1.0
Error: Execution error: (Hint: you may increase the file descriptor limit
with shell command 'ulimit -n 4096') Failed to create partition file at
"/var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/.tmp2YLiiK/.tmp8w9Wx2": Os {
code: 24, kind: Uncategorized, message: "Too many open files" }
```
However, when I cranked the ulimit via
```shell
ulimit -n 10000
```
Then it fails like this
```
3:~/Software/datafusion$ ./target/profiling/datafusion-cli -m 1G -c "SELECT
\"UserID\", extract(minute FROM to_timestamp_seconds(\"EventTime\")) AS m,
\"SearchPhrase\", COUNT(*) FROM
'/Users/andrewlamb/Software/datafusion/benchmarks/data/hits_partitioned' GROUP
BY \"UserID\", m, \"SearchPhrase\" ORDER BY COUNT(*) DESC LIMIT 10;"
DataFusion CLI v52.1.0
Error: Resources exhausted: Additional allocation failed for TopK[7] with
top memory consumers (across reservations) as:
GroupedHashAggregateStream[7] (count(1))#48(can spill: true) consumed 83.8
MB, peak 83.8 MB,
GroupedHashAggregateStream[4] (count(1))#26(can spill: true) consumed 83.8
MB, peak 83.8 MB,
GroupedHashAggregateStream[15] (count(1))#64(can spill: true) consumed
79.1 MB, peak 79.1 MB.
Error: Failed to allocate additional 2.3 MB for TopK[7] with 7.4 MB already
allocated for this reservation - 334.3 KB remain available for the total pool
```
That being said, this seems like an improvement to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
