alamb commented on code in PR #20159:
URL: https://github.com/apache/datafusion/pull/20159#discussion_r2771477998
##########
datafusion/physical-plan/src/spill/spill_pool.rs:
##########
@@ -194,6 +194,8 @@ impl SpillPoolWriter {
// Append the batch
if let Some(ref mut writer) = file_shared.writer {
writer.append_batch(batch)?;
+ // make sure we flush the writer for readers
Review Comment:
I do wonder if it is ok to flush each batch (will this result in too many
small file IOs?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
