peterxcli commented on PR #20358: URL: https://github.com/apache/datafusion/pull/20358#issuecomment-3902207291
There are test failures: https://github.com/apache/datafusion/actions/runs/22020622330/job/63629163510?pr=20358#step:8:8134 ```sql test cases::plan_to_sql::roundtrip_statement ... ok test result: ok. 451 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.24s Running unittests src/lib.rs (target/ci/deps/datafusion_sqllogictest-8469134fa1d97a69) running 2 tests test util::tests::ignore_marker_does_not_skip_leading_text ... ok test engines::conversion::tests::test_big_decimal_to_str ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running bin/sqllogictests.rs (target/ci/deps/sqllogictests-2ee8f49c22e98e3a) External error: 3 errors in file /__w/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/collection/size.slt 1. query result mismatch: [SQL] SELECT size(map(make_array('a', 'b', 'c'), make_array(1, 2, 3))); [Diff] (-expected|+actual) - 3 + 1 at /__w/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/collection/size.slt:62 2. query result mismatch: [SQL] SELECT size(map(arrow_cast(make_array(), 'List(Utf8)'), arrow_cast(make_array(), 'List(Int32)'))); [Diff] (-expected|+actual) - 0 + 1 at /__w/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/collection/size.slt:93 3. query result mismatch: [SQL] SELECT size(column1) FROM VALUES (map(['a'], [1])), (map(['a','b'], [1,2])), (NULL); [Diff] (-expected|+actual) 1 - 2 + 1 -1 ``` but I think I will just correct the sql in size.slt as that's not the stand usage of spark sql of map function. ref: https://spark.apache.org/docs/4.2.0-preview2/api/sql/map-functions/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
