peterxcli commented on PR #20358: URL: https://github.com/apache/datafusion/pull/20358#issuecomment-3908083939
> Thanks @peterxcli why we cannot just use internal DF `map` function? Spark crate functions are overloads for already existing DF functions to follow Spark specifics, do you see something where built in `map` doesn't follow the one from Spark? The built-in DataFusion map function has a different argument order and type signature compared to Spark's map. I'm not sure if we can reorder the arguments on the Comet side—is there another function doing something similar? Even if we could, we would still need to write Scala code to handle type casting and Arrow formatting, which seems like a significant effort. WDYT? ref: https://github.com/apache/datafusion/blob/ffcc7e3af8cfccb0c0705de2112d8277b28114fd/datafusion/functions-nested/src/map.rs#L195-L238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
