martin-g commented on PR #20278: URL: https://github.com/apache/datafusion/pull/20278#issuecomment-3907120425
It is hard to tell :-/ I have to make a new full code review. IMO force-pushes should be avoided. The PR is squashed anyway when merging. Incremental code reviews are more reviewer-friendly. One of the "Compare" links above (https://github.com/apache/datafusion/compare/880029d6563a805df752ccb8ce15e946c41ec9e6..f6cc4646cc8e4b252f0532886253b2aa607a3d40) shows diffs even in datafusion-cli crate but they are not in the full diff (`.../20278/changes) ... I'll try to make a full review again later/tomorrow! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
