neilconway commented on PR #20278:
URL: https://github.com/apache/datafusion/pull/20278#issuecomment-3908188673
@martin-g Sorry about that! The "Compare" link has a lot of extraneous
changes because I rebased the branch against the latest main. If you search for
"rpad.rs" you can see the only changes I made to the PR itself: I just noticed
a few other spots where we can combine `write_str(x)` + `append_value("")` into
a single `append_value(x)` call.
On rebasing in general, that's good to know! I've previously worked mostly
on projects that use a more rebase-centric workflow. I'm happy to avoid
unnecessary rebases in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
