neilconway commented on code in PR #20945:
URL: https://github.com/apache/datafusion/pull/20945#discussion_r2937013729
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -307,6 +307,34 @@ fn try_coerce_types(
)
}
+fn data_types_match(valid_types: &[DataType], current_types: &[DataType]) ->
bool {
Review Comment:
Seems like we aren't handling Map, Struct, or ListView -- is there a reason
for that? In fact, the original bug report uses Map.
I wonder if we can simplify this to use `equals_datatype` from Arrow, as
suggested by the bug reporter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
