neilconway commented on code in PR #20945:
URL: https://github.com/apache/datafusion/pull/20945#discussion_r2941421186
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -307,6 +307,34 @@ fn try_coerce_types(
)
}
+fn data_types_match(valid_types: &[DataType], current_types: &[DataType]) ->
bool {
Review Comment:
Thank you! That makes sense: the key point is that some Arrow kernels depend
on struct field ordering, but the "field name" of a list has no influence on
the representation of the data. Can we add a brief comment to
`data_type_matches` to explain the rationale for the kinda-structural-equality
we are implementing?
It seems like `Map` has the same behavior as the `List` variants: the "field
name" does not impact the representation of the data. Should we handle that as
well, for completeness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
