Re: [PR] Replace ahash with foldhash for faster hashing in datafusion-common [datafusion]

Mon, 16 Mar 2026 06:12:48 -0700 


adriangbot commented on PR #20958:
URL: https://github.com/apache/datafusion/pull/20958#issuecomment-4067568231

   ๐Ÿค– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/20958#issuecomment-4067452276)
   
   <details><summary>Details</summary>
   <p>
   
   ```
   Comparing HEAD and foldhash-hashing
   --------------------
   Benchmark clickbench_extended.json
   --------------------
   
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query    โ”ƒ                                     HEAD โ”ƒ                      
   foldhash-hashing โ”ƒ        Change โ”ƒ
   
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 0 โ”‚       837.21 / 852.18 ยฑ14.24 / 878.58 ms โ”‚        804.40 / 
817.29 ยฑ9.43 / 828.18 ms โ”‚     no change โ”‚
   โ”‚ QQuery 1 โ”‚        227.69 / 229.14 ยฑ0.97 / 230.59 ms โ”‚        205.52 / 
206.46 ยฑ0.73 / 207.34 ms โ”‚ +1.11x faster โ”‚
   โ”‚ QQuery 2 โ”‚        539.82 / 543.04 ยฑ2.23 / 546.24 ms โ”‚        494.41 / 
497.67 ยฑ2.48 / 501.78 ms โ”‚ +1.09x faster โ”‚
   โ”‚ QQuery 3 โ”‚        332.66 / 334.40 ยฑ0.95 / 335.52 ms โ”‚        316.22 / 
317.22 ยฑ1.01 / 319.03 ms โ”‚ +1.05x faster โ”‚
   โ”‚ QQuery 4 โ”‚       679.60 / 706.39 ยฑ15.88 / 725.58 ms โ”‚       661.89 / 
683.66 ยฑ13.14 / 701.34 ms โ”‚     no change โ”‚
   โ”‚ QQuery 5 โ”‚ 9792.53 / 10044.39 ยฑ206.48 / 10393.16 ms โ”‚ 9849.85 / 10093.84 
ยฑ234.40 / 10430.73 ms โ”‚     no change โ”‚
   โ”‚ QQuery 6 โ”‚      981.39 / 997.12 ยฑ15.86 / 1027.36 ms โ”‚        979.91 / 
988.26 ยฑ5.64 / 995.95 ms โ”‚     no change โ”‚
   โ”‚ QQuery 7 โ”‚        790.42 / 799.78 ยฑ6.67 / 810.25 ms โ”‚       787.77 / 
845.31 ยฑ54.15 / 916.42 ms โ”‚  1.06x slower โ”‚
   
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary               โ”ƒ            โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)               โ”‚ 14506.44ms โ”‚
   โ”‚ Total Time (foldhash-hashing)   โ”‚ 14449.70ms โ”‚
   โ”‚ Average Time (HEAD)             โ”‚  1813.30ms โ”‚
   โ”‚ Average Time (foldhash-hashing) โ”‚  1806.21ms โ”‚
   โ”‚ Queries Faster                  โ”‚          3 โ”‚
   โ”‚ Queries Slower                  โ”‚          1 โ”‚
   โ”‚ Queries with No Change          โ”‚          4 โ”‚
   โ”‚ Queries with Failure            โ”‚          0 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   </p>
   </details>
   
   <details><summary>Resource Usage</summary>
   
   **clickbench_extended โ€” base (merge-base)**
   | Metric | Value |
   |--------|-------|
   | Wall time | 73.2s |
   | Peak memory | 32.5 GiB |
   | Avg memory | 27.1 GiB |
   | CPU user | 725.3s |
   | CPU sys | 22.8s |
   | Disk read | 0 B |
   | Disk write | 21.8 MiB |
   
   **clickbench_extended โ€” branch**
   | Metric | Value |
   |--------|-------|
   | Wall time | 72.7s |
   | Peak memory | 30.7 GiB |
   | Avg memory | 25.2 GiB |
   | CPU user | 715.9s |
   | CPU sys | 27.7s |
   | Disk read | 0 B |
   | Disk write | 724.0 KiB |
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to