Dandandan commented on code in PR #20958:
URL: https://github.com/apache/datafusion/pull/20958#discussion_r2941275826
##########
datafusion/core/tests/sql/unparser.rs:
##########
@@ -368,8 +357,9 @@ async fn collect_results(ctx: &SessionContext, original:
&str) -> TestCaseResult
}
};
- // Sort if needed for comparison
- if !is_sorted {
+ // Always sort for deterministic comparison — even "sorted" results can
have
+ // tied rows in different order between original and unparsed SQL.
Review Comment:
The reason it now fails is
`RandomState::default()` of foldhash giving a random seed on each call,
instead of returning the same random one that is generated once and reused
after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
