alamb commented on PR #21260: URL: https://github.com/apache/datafusion/pull/21260#issuecomment-4164516052
Thank you so much @RafaelHerrero -- this sounds right to me > Proposed next steps: > > 1. Open a PR to apache/datafusion-testing with the 279 updated .slt files > 2. Once merged, update the submodule reference in this PR Yes, thank you -- this sounds right Can I also request a step 3 (which is to update the `datafusion/sqllogictest/regenerate_sqlite_files.sh` so it uses an updated fork of sqllogictests)? I can make a fork for us in `datafusion-contrib` perhaps I also wonder if there is something we can upstream to the sqllogictest repo so we don't have to maintain a fork -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
