rluvaton commented on code in PR #22064:
URL: https://github.com/apache/datafusion/pull/22064#discussion_r3201106216
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -1611,6 +1611,12 @@ impl NestedLoopJoinStream {
}
}
+ // If the left stream is fully exhausted, release its resources so the
+ // upstream pipeline can be torn down before we move on to probing.
+ if self.left_exhausted {
+ active.left_stream = None;
+ }
Review Comment:
maybe there are cases that left exhausted is true and left stream is not
None, because what is the reason to have both exhausted flag and Option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]