rluvaton commented on code in PR #22064:
URL: https://github.com/apache/datafusion/pull/22064#discussion_r3201116565
##########
datafusion/physical-plan/src/spill/replayable_spill_input.rs:
##########
@@ -282,6 +282,9 @@ impl Stream for ReplayableSpillStream {
}
// The stream is exhausted, give the inner state ownership back to
`ReplayableStreamSource`
Poll::Ready(None) => {
+ // Release the input pipeline's resources.
+ this.inner =
+
Box::pin(EmptyRecordBatchStream::new(Arc::clone(&this.schema)));
Review Comment:
I think to avoid bugs the schema for inner should be kept the same and not
use `this.schema` (even when they are the same schema) because you only want to
release the stream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
