neilconway commented on code in PR #22104:
URL: https://github.com/apache/datafusion/pull/22104#discussion_r3221951243
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -903,7 +903,17 @@ impl AsLogicalPlan for LogicalPlanNode {
}
};
- builder.build()
+ // The builder paths above hardcode `null_aware = false`, so
Review Comment:
Rather than first constructing the join with an incorrect `null_aware` field
and then overwriting it here, can we try ensuring that the `null_aware` field
is correct when the join is constructed? That would be more robust and avoids
the intermediate period where we've constructed a value but it is in an
incorrect state.
i.e., something like
https://gist.github.com/neilconway/2dc2449dcf4cca3a60e1861e445e042c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
