mithuncy commented on code in PR #22104:
URL: https://github.com/apache/datafusion/pull/22104#discussion_r3222138951
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -903,7 +903,17 @@ impl AsLogicalPlan for LogicalPlanNode {
}
};
- builder.build()
+ // The builder paths above hardcode `null_aware = false`, so
Review Comment:
@neilconway Thanks a lot — much cleaner than mine, and it also fixes the
null_equality drop on the same path.
I'll apply, re-run tests, and edit the now-obsolete null_equality related
paragraph from the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
