milenkovicm commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4509820388
Thats main point i'm trying to get across, it's a bit undefined whats expected from this method. please dont get me wrong I'm not trying to make a case this is not useful. I'm a bit confused how to handle df.54 upgrade, when it is safe to ignore it. if `Ok(Continue)` is undeterministic, is it the right return type ? > I share the same concern as @alamb that it would not be safe Can we mention in the upgrade guide in which cases this method is safe/unsafe to ignore ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
