adriangb commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4510588506
> if we tell people "It is ok to leave Ok()" in your implementation (or add a default implementation) then aren't we leaving a time bomb for them if we do start using apply_expressions in the future? yes agreed hence why the plan was never to tell people "it is ok to leave Ok()" and the implementation forces users to implement it. @milenkovicm suggested leaving `Ok()` (contradicting the current implementation and documentation) and I've been trying to help clarify why that would not cause issues today but would cause issues in the future as soon as this method starts being used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
