Jefffrey commented on code in PR #22089:
URL: https://github.com/apache/datafusion/pull/22089#discussion_r3292213923
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -338,7 +342,7 @@ impl LogicalPlanBuilder {
// since the code loop skips NULL
fields.push_with_metadata(
common_type.unwrap_or(DataType::Null),
Review Comment:
What happens if `common_type` isn't set? We get a null datatype that isn't
nullable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
