Xuanwo commented on code in PR #22951:
URL: https://github.com/apache/datafusion/pull/22951#discussion_r3434427676
##########
datafusion/ffi/src/session/mod.rs:
##########
@@ -504,6 +509,15 @@ fn table_options_from_rhashmap(options: SVec<(SString,
SString)>) -> TableOption
.unwrap_or_else(|err| log::warn!("Error parsing table options:
{err}"));
}
}
+ #[cfg(not(feature = "parquet"))]
+ for (key, value) in options.iter().filter_map(|(k, v)| {
+ let (prefix, key) = k.split_once(".")?;
+ (prefix == "parquet").then(|| (key, v))
+ }) {
+ table_options.parquet.set(key, value).unwrap_or_else(|err| {
+ log::warn!("Error parsing parquet table option: {err}")
+ });
+ }
Review Comment:
yep, I want to print some warnings while users passing parquet options but
parquet didn't enabled. I'm open to just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
