lyne7-sc commented on code in PR #22905:
URL: https://github.com/apache/datafusion/pull/22905#discussion_r3436666254
##########
datafusion/functions/src/string/lower.rs:
##########
@@ -57,9 +57,12 @@ impl LowerFunc {
pub fn new() -> Self {
Self {
signature: Signature::coercible(
- vec![Coercion::new_exact(TypeSignatureClass::Native(
- logical_string(),
- ))],
+ vec![
+
Coercion::new_exact(TypeSignatureClass::Native(logical_string()))
+ .with_encoding_preservation(
+ EncodingPreservation::default().with_dictionary(),
Review Comment:
added `EncodingPreservation::dictionary()` as the constructor.
##########
datafusion/functions/src/string/lower.rs:
##########
@@ -118,6 +123,52 @@ mod tests {
Ok(())
}
+ fn invoke_lower_scalar(input: ScalarValue) -> Result<ScalarValue> {
Review Comment:
done, moved these tests to SLTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
