gene-bordegaray commented on code in PR #22657:
URL: https://github.com/apache/datafusion/pull/22657#discussion_r3454920186
##########
datafusion/datasource/src/file_scan_config/mod.rs:
##########
@@ -700,56 +773,55 @@ impl DataSource for FileScanConfig {
Ok(source.map(|s| Arc::new(s) as _))
}
- /// Returns the output partitioning for this file scan.
+ /// Returns declared or derived output partitioning for this file scan.
///
- /// When `partitioned_by_file_group` is true, this returns
`Partitioning::Hash` on
- /// the Hive partition columns, allowing the optimizer to skip hash
repartitioning
- /// for aggregates and joins on those columns.
+ /// Declared partitioning is projected through the scan projection. If it
+ /// cannot be projected, or its partition count differs from `file_groups`,
+ /// this returns `UnknownPartitioning`.
///
- /// Tradeoffs
Review Comment:
Seemed like long docs that I thought would be better on the fields
themselves, that's why I added:
https://github.com/apache/datafusion/pull/22657/changes/BASE..ba15301de16ce79e7e84c134961c75e9ca4653b8#diff-a07222d670257887f5118197c485861c96635e2da6c2bf0007d2c21dda7df82aR206
It is shorter but still is same idea, I can revert this and modify if its
preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
