gene-bordegaray commented on code in PR #22657:
URL: https://github.com/apache/datafusion/pull/22657#discussion_r3455364684
##########
datafusion/catalog-listing/src/options.rs:
##########
@@ -53,6 +53,20 @@ pub struct ListingOptions {
/// multiple equivalent orderings, the outer `Vec` will have a
/// single element.
pub file_sort_order: Vec<Vec<SortExpr>>,
+ /// Declared output partitioning for scans from this table.
+ ///
+ /// Expressions are logical expressions over the full table schema. When
set,
+ /// [`ListingTable`](crate::ListingTable) creates one file group per
+ /// declared output partition, preserving empty groups. When unset, file
+ /// grouping uses the scan-time
+ ///
[`SessionConfig::target_partitions`](datafusion_execution::config::SessionConfig::target_partitions).
+ /// Declarations are limited to partitioning that can be represented by
+ /// assigning whole files to file groups.
+ ///
+ /// Files are assigned to groups in path order. DataFusion does not
validate
Review Comment:
added two examples and made more clear. Let me know if that ocvers the cases
you had in mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
