oc7o commented on PR #23188: URL: https://github.com/apache/datafusion/pull/23188#issuecomment-4846131233
@kosiew I gotta thank you for the effort you put into this. It was really with the eye for detail andI really learned a lot! 😊 I think with how it now is we're a bit closer to the standard SQL implementation. Maybe (when this PR is ready 🤞) escaping could be a good follow up topic for me. Since we currently still treat `\` as a literal. So that `'a%' SIMILAR TO 'a\%'` then returns true. Currently it would return false. I'm curios for any responses! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
