oc7o commented on PR #23188: URL: https://github.com/apache/datafusion/pull/23188#issuecomment-4948238843
@kosiew Thx again for the review. I learn so much new stuff when working here! I now added support for dynamic values on the RHS alongside some bug fixes like for the `SIMILAR TO NULL` expression. One issue still is that datafusion-proto can't serialize `SqlSimilarToPattern` but I would argue that this is out of scope for this PR. Also a decision I consciously made was disregarding strings inside `Dictionary` and `RunEndEncoded` for now. 🐙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
