LiaCastaneda commented on code in PR #22853:
URL: https://github.com/apache/datafusion/pull/22853#discussion_r3518985868
##########
datafusion/physical-expr/src/expressions/lambda.rs:
##########
@@ -129,6 +141,7 @@ impl LambdaExpr {
body,
projected_body,
projection,
+ used_params: used_param_names,
Review Comment:
Since `used_param_names` is already computed here during construction, could
the fix live entirely in `projected_body` instead? Rather than threading
`used_params` through to `LambdaArgument`, then LambdaArgument stays unchanged
and external callers don't need to think about used params at all
Left a rough idea here
https://github.com/LiaCastaneda/datafusion/commit/993ac377f92be94a42b0989a32ef5b6e3b171a03
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
