ratmice opened a new pull request, #23387:
URL: https://github.com/apache/datafusion/pull/23387
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #23386.
## Rationale for this change
Customizing datafusion-cli with custom udf or calling `register_*` currently
requires copying all of `main.rs`,
then dealing with the workspace dependencies required to build it, and
change it to link against the `datafusion-cli` library.
If one just wants an example cli without much hassle and maintenance, it is
a bit much when you hope to just add a couple lines.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
The first patch moves a lot of main_inner to a new struct `ClientSession`,
that then makes it a lot simpler.
Included is an example of registering a cli-custom-udf.rs.
The second patch just reformats the code with rustfmt to deal with the
addition of indentation by moving
things into an `impl CliSession`.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
I tested these by running the `datafusion-cli` and running `select
hello(1);` in the new example.
Otherwise this doesn't change any existing library code.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
