ratmice commented on PR #23387:
URL: https://github.com/apache/datafusion/pull/23387#issuecomment-4918278114
After sleeping on it, there are definitely a few things this patch could do
better.
1. Hard coding of "DataFusion CLI {DATAFUSION_CLI_VERSION}"
2. Calling `Args::parse` which will exit instead of `Args::try_parse` or
`Args::try_parse_from` which will return a `Result`.
3. Probably should just bite the bullet and make `Args` public, extending
the existing example to use the command line arguments for configuring it's
`CliSessionContext`, instead of calling `SessionContext::new()`.
4. That'll require taking a `CliSessionContext` parameter, and probably
taking ownership of `PrintOptions` from a `CliSession`, perhaps the fields of
`CliSession` should just be `pub`?.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
