manuzhang commented on code in PR #4821: URL: https://github.com/apache/datafusion-comet/pull/4821#discussion_r3556160392
########## docs/source/user-guide/latest/expressions.md: ########## @@ -278,13 +278,13 @@ The type-name conversion functions (`bigint`, `binary`, `boolean`, `date`, `deci | `quarter` | ✅ | | | `second` | ✅ | | | `session_window` | 🔜 | Batch session-window grouping falls back (`UpdatingSessionsExec` is not yet native); tracked by [#4785](https://github.com/apache/datafusion-comet/issues/4785) | -| `time_diff` | 🔜 | Spark 4.1 TIME type; tracked by [#4288](https://github.com/apache/datafusion-comet/issues/4288) | -| `time_trunc` | 🔜 | Spark 4.1 TIME type; tracked by [#4288](https://github.com/apache/datafusion-comet/issues/4288) | +| `time_diff` | ✅ | Spark 4.1+; routes through the JVM codegen dispatcher | +| `time_trunc` | ✅ | Spark 4.1+; routes through the JVM codegen dispatcher | | `timestamp_micros` | ✅ | | | `timestamp_millis` | ✅ | | | `timestamp_seconds` | ✅ | | | `to_date` | ✅ | Rewrites to `Cast` (or `Cast(GetTimestamp)` with a format) before Comet sees the plan | -| `to_time` | 🔜 | Spark 4.1 TIME type; tracked by [#4288](https://github.com/apache/datafusion-comet/issues/4288) | +| `to_time` | ✅ | Spark 4.1+ | Review Comment: This implies that all `to_time` forms are supported, but the Spark 4.1 shim still only handles the one-argument form with no explicit format (`fmt.isEmpty && args.size == 1`). The existing SQL tests expect formatted `to_time` and `try_to_time` calls to fall back. Could we update both this row and the `try_to_time` row on line 297 to say that only the default-format form is supported, or route the formatted forms through JVM codegen dispatch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
