github-actions[bot] commented on PR #23903: URL: https://github.com/apache/datafusion/pull/23903#issuecomment-5122698033
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 110.058s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.038s] (current) Building datafusion v54.1.0 (baseline) Built [ 107.022s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.915s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 221.373s] datafusion Building datafusion-catalog v54.1.0 (current) Built [ 39.202s] (current) Parsing datafusion-catalog v54.1.0 (current) Parsed [ 0.027s] (current) Building datafusion-catalog v54.1.0 (baseline) Built [ 39.013s] (baseline) Parsing datafusion-catalog v54.1.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion-catalog v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.143s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 79.604s] datafusion-catalog Building datafusion-datasource v54.1.0 (current) Built [ 38.973s] (current) Parsing datafusion-datasource v54.1.0 (current) Parsed [ 0.034s] (current) Building datafusion-datasource v54.1.0 (baseline) Built [ 39.997s] (baseline) Parsing datafusion-datasource v54.1.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion-datasource v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.373s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 80.636s] datafusion-datasource Building datafusion-ffi v54.1.0 (current) Built [ 62.997s] (current) Parsing datafusion-ffi v54.1.0 (current) Parsed [ 0.066s] (current) Building datafusion-ffi v54.1.0 (baseline) Built [ 62.567s] (baseline) Parsing datafusion-ffi v54.1.0 (baseline) Parsed [ 0.068s] (baseline) Checking datafusion-ffi v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.318s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 127.693s] datafusion-ffi Building datafusion-physical-optimizer v54.1.0 (current) Built [ 43.004s] (current) Parsing datafusion-physical-optimizer v54.1.0 (current) Parsed [ 0.024s] (current) Building datafusion-physical-optimizer v54.1.0 (baseline) Built [ 43.519s] (baseline) Parsing datafusion-physical-optimizer v54.1.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-physical-optimizer v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.153s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 87.878s] datafusion-physical-optimizer Building datafusion-physical-plan v54.1.0 (current) Built [ 39.090s] (current) Parsing datafusion-physical-plan v54.1.0 (current) Parsed [ 0.154s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 39.976s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.153s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.948s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_marked_deprecated: trait method #[deprecated] added --- Description: A trait method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_marked_deprecated.ron Failed in: method with_new_children in trait datafusion_physical_plan::execution_plan::ExecutionPlan in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/execution_plan.rs:98 method with_new_children_and_same_properties in trait datafusion_physical_plan::execution_plan::ExecutionPlan in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/execution_plan.rs:98 method with_new_children in trait datafusion_physical_plan::ExecutionPlan in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/execution_plan.rs:98 method with_new_children_and_same_properties in trait datafusion_physical_plan::ExecutionPlan in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/execution_plan.rs:98 Summary semver requires new minor version: 0 major and 1 minor checks failed Finished [ 81.623s] datafusion-physical-plan Building datafusion-proto v54.1.0 (current) Built [ 65.271s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 64.055s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.352s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 131.104s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
