peterxcli commented on issue #23817:
URL: https://github.com/apache/datafusion/issues/23817#issuecomment-5139892005

   > ```rust
   > struct PartitionedFilterExpr {
   >     partitioning: Partitioning, // ex. Partitioning=Hash(column_a, 12)
   >     partition_expr: Arc<dyn PhysicalExpr>, // ex. hash(column_a)
   >     cases: BTreeMap<u64, Arc<dyn PhysicalExpr>>, // map of partition id to 
filter expr 
   > }
   > ```
   
   This structure looks good, I have two comments:
   1. `cases` could be simple list, right? because partitions id must be 
continuous.
   2. for `partition_expr`, if want to fit range partitioning in this 
structure, then it would sth like:
   ```sql
   CASE
      WHEN key <range split[0] THEN 0
      WHEN key <range split[1] THEN 1
      ...
      ELSE n
   END
   ```
   per https://github.com/apache/datafusion/issues/23376#issuecomment-5047433301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to