saadtajwar opened a new pull request, #24070:
URL: https://github.com/apache/datafusion/pull/24070

   ## Which issue does this PR close?
   
   - Closes #23994
   
   ## Rationale for this change
   
   Currently `RowsGroupColumn`'s `take_n` method knows the remaining number of 
rows and bytes after taking the first n group rows, but when invoking 
`empty_rows` passes in 0 for the row capacity and data capacity parameters 
instead of the known remainders, potentially causing unnecessary copying and 
allocating
   
   ## What changes are included in this PR?
   
   Using the known remaining number of rows and bytes in the invocation to 
`empty_rows`
   
   ## Are these changes tested?
   
   Yes
   
   ## Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to