saadtajwar commented on code in PR #24070:
URL: https://github.com/apache/datafusion/pull/24070#discussion_r3714005934
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/row_backed.rs:
##########
@@ -425,6 +429,84 @@ mod tests {
assert_eq!(g0, 20);
}
+ /// `take_n` preallocates the retained-row buffer from the known row
Review Comment:
Thanks - pushed a change to exercise this directly! Please let me know your
thoughts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
