jayshrivastava commented on code in PR #24068:
URL: https://github.com/apache/datafusion/pull/24068#discussion_r3730503727
##########
datafusion/ffi/src/execution_plan.rs:
##########
@@ -474,15 +498,18 @@ impl ExecutionPlan for ForeignExecutionPlan {
#[cfg(any(test, feature = "integration-tests"))]
pub mod tests {
- use datafusion_physical_plan::Partitioning;
+ #[cfg(test)]
Review Comment:
It's needed right now because `DynamicFilterPhysicalExpr` was unused when
compiling under `integration-tests`. I'll lifted the usage into a helper method
so we don't need the `#[cfg(test)]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
